[
https://issues.apache.org/jira/browse/DRILL-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609336#comment-14609336
]
Jason Altekruse commented on DRILL-3433:
----------------------------------------
I agree that this should be documented better, but I think I can offer a little
clarification about the testing vs non-testing. DrillConfig is something that
should be shared throughout the system as soon as it is created at Drillbit
startup. The values stored here are not modifiable without restarting the
Drillbit. Throughout the server code this Drill config should not be created by
anyone who wants access to the values stored in the class, they should find a
way to request the config from the root reference to the Drillbit itself.
I know that we currently do not have a clean division between client and server
code in the source, and that we should definitely move some shared code to a
common module, the best examples I can think of are the RPC and ValueVector
code. I do not know if the DrillConfig object is meaningful on the client, it
is also possible that only a subset of the options stored there are meaningful
to clients. The fact that the allocator is shared between the client and the
server necessitates creating a DrillConfig on the client as is being done in
DrillConnectionImpl.
> DrillConfig.create(Properties) used outside of testing code
> -----------------------------------------------------------
>
> Key: DRILL-3433
> URL: https://issues.apache.org/jira/browse/DRILL-3433
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Daniel Barclay (Drill)
>
> The method description of DrillConfig.create(Properties) says:
> Do not use this method outside of test code.
> However, it is called in DrillConnectionImpl(...).
> Additionally, that method description doesn't say anything about what
> DrillConfig.create(Properties) actually does (why it's for testing vs. for
> non-testing use).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
