[
https://issues.apache.org/jira/browse/DRILL-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611111#comment-14611111
]
Deneche A. Hakim commented on DRILL-3448:
-----------------------------------------
One more thing, what happens if all the fragments in the dead drillbit already
finished successfully ?DrillbitStatusListener.drillbitUnregistered() doesn't
seem to check for this case and the query would still fail (after we fix the
typo)
> typo in QueryManager.DrillbitStatusListener will cause the Foreman to hang if
> a Drillbit dies
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-3448
> URL: https://issues.apache.org/jira/browse/DRILL-3448
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 1.0.0
> Reporter: Deneche A. Hakim
> Assignee: Deneche A. Hakim
> Priority: Critical
> Fix For: 1.2.0
>
>
> at the end of DrillbitStatusListener.drillbitUnregistered() there is if block:
> {code}
> if (!atLeastOneFailure) {
> logger.warn("...");
> stateListener.moveToState(QueryState.FAILED,
> new ForemanException(...));
> }
> {code}
> this will basically fail the query if the drillbit DIDN'T contain any
> fragment for this Foreman, which in fact should be the inverse.
> I will most likely fix this as part of DRILL-3167 as I need to make changes
> to the listener.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)