[
https://issues.apache.org/jira/browse/DRILL-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623108#comment-14623108
]
ASF GitHub Bot commented on DRILL-2650:
---------------------------------------
Github user cwestin commented on a diff in the pull request:
https://github.com/apache/drill/pull/80#discussion_r34406507
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -695,7 +697,10 @@ public void close() {
Preconditions.checkState(!isClosed);
Preconditions.checkState(resultState != null);
- logger.info("foreman cleaning up.");
+ // to track how long the query takes
+ queryManager.markEndTime();
+
+ logger.info(queryIdString + ": cleaning up.");
--- End diff --
.info() seems like it will generate a lot of noise here, should it be
.debug()?
> Cancelled queries json profile shows query end time occurs before fragments
> end time
> -------------------------------------------------------------------------------------
>
> Key: DRILL-2650
> URL: https://issues.apache.org/jira/browse/DRILL-2650
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
> Affects Versions: 0.9.0
> Reporter: Krystal
> Assignee: Jacques Nadeau
> Fix For: 1.2.0
>
> Attachments: DRILL-2650.1.patch.txt
>
>
> I have a query that was successfully cancelled. The query start and end time
> is as follows:
> "type": 1,
> "start": 1427839192049,
> "end": 1427839194966,
> This translates to a query duration of about 3 seconds. However, the
> duration of the query's fragments are much longer up to more than 6 seconds.
> Here is an entry for majorFragmentId=0 with a duration of 6.6 seconds:
> "startTime": 1427839192796,
> "endTime": 1427839199408,
> 8 out of 11 major fragments have duration greater than the query itself. To
> an end user, this is confusing and does not make sense. We should wait for
> all of the major fragments to be completely cancelled before updating the the
> "end" time of the query.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
