[
https://issues.apache.org/jira/browse/DRILL-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627208#comment-14627208
]
ASF GitHub Bot commented on DRILL-3122:
---------------------------------------
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/92
DRILL-3122: Changing a session option to default value results in status as
changed
@jaltekruse please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudheeshkatkam/drill DRILL-3122
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 3c09355931a4466587dea1404319f57fef3f779a
Author: Sudheesh Katkam <[email protected]>
Date: 2015-07-13T23:56:58Z
DRILL-3122: Ignore OptionType for option status
----
> Changing a session option to default value results in status as changed
> -----------------------------------------------------------------------
>
> Key: DRILL-3122
> URL: https://issues.apache.org/jira/browse/DRILL-3122
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.0.0
> Reporter: Ramana Inukonda Nagaraj
> Assignee: Sudheesh Katkam
> Fix For: 1.2.0
>
> Attachments: DRILL-3122.1.patch.txt
>
>
> Alter session option hash join to true(which is the default) and the
> following query shows that the option has changed which could be misleading
> to users relying on the status field to see if an option has changed or not.
> Especially in the case of a boolean value.
> {code}
> 0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name
> like '%hash%';
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> | name | kind | type | status
> | num_val | string_val | bool_val | float_val |
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> | exec.max_hash_table_size | LONG | SYSTEM | DEFAULT
> | 1073741824 | null | null | null |
> | exec.min_hash_table_size | LONG | SYSTEM | DEFAULT
> | 65536 | null | null | null |
> | planner.enable_hash_single_key | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashagg | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashjoin | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashjoin_swap | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.join.hash_join_swap_margin_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 10.0 |
> | planner.memory.hash_agg_table_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 1.1 |
> | planner.memory.hash_join_table_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 1.1 |
> +--------------------------------------------+----------+---------+----------+-------------+-------------+-----------+------------+
> 9 rows selected (0.191 seconds)
> 0: jdbc:drill:zk=10.10.100.171:5181> alter session set
> `planner.enable_hashjoin`=true;
> +-------+-----------------------------------+
> | ok | summary |
> +-------+-----------------------------------+
> | true | planner.enable_hashjoin updated. |
> +-------+-----------------------------------+
> 1 row selected (0.083 seconds)
> 0: jdbc:drill:zk=10.10.100.171:5181> select * from sys.options where name
> like '%hash%';
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> | name | kind | type | status
> | num_val | string_val | bool_val | float_val |
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> | exec.max_hash_table_size | LONG | SYSTEM | DEFAULT
> | 1073741824 | null | null | null |
> | exec.min_hash_table_size | LONG | SYSTEM | DEFAULT
> | 65536 | null | null | null |
> | planner.enable_hash_single_key | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashagg | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashjoin | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.enable_hashjoin | BOOLEAN | SESSION | CHANGED
> | null | null | true | null |
> | planner.enable_hashjoin_swap | BOOLEAN | SYSTEM | DEFAULT
> | null | null | true | null |
> | planner.join.hash_join_swap_margin_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 10.0 |
> | planner.memory.hash_agg_table_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 1.1 |
> | planner.memory.hash_join_table_factor | DOUBLE | SYSTEM | DEFAULT
> | null | null | null | 1.1 |
> +--------------------------------------------+----------+----------+----------+-------------+-------------+-----------+------------+
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
