[
https://issues.apache.org/jira/browse/DRILL-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635652#comment-14635652
]
Jacques Nadeau commented on DRILL-3500:
---------------------------------------
-1 until this is better rationalized against the other query planning related
context objects.
These seems like an excessive context addition. With this change we would have
four query planning related contexts: QueryContext, QueryContextInformation,
PlannerSettings and now QueryRulesContext. What is the rational for each and
why do we need an additional one?
> Provide additional information while registering storage plugin optimizer
> rules
> -------------------------------------------------------------------------------
>
> Key: DRILL-3500
> URL: https://issues.apache.org/jira/browse/DRILL-3500
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Mehant Baid
> Assignee: Mehant Baid
> Fix For: 1.2.0
>
>
> Currently all the optimizer rules internal to Drill have access to
> QueryContext. This is used by a few rules like PruneScanRule which invoke the
> interpreter to perform partition pruning. However the rules that belong to
> specific storage plugins don't have access to this information. This JIRA
> aims to do the following
> 1. Add a new interface OptimizerRulesContext that will be implemented by
> QueryContext. It will contain all the information needed by the rules. This
> context will be passed to the storage plugin method while getting the
> optimizer rules specific to that storage plugin.
> 2. Restrict existing internal rules to only accept OptimizerRulesContext
> instead of QueryContext so information in QueryContext has better
> encapsulation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
