[ 
https://issues.apache.org/jira/browse/DRILL-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643119#comment-14643119
 ] 

Aditya Kishore commented on DRILL-3364:
---------------------------------------

{noformat}
diff --git 
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java
 
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java
index 177ae52..785b2e3 100644
--- 
a/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java
+++ 
b/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/IntBEConvertFrom.java
@@ -26,7 +26,8 @@ import org.apache.drill.exec.expr.annotations.Param;
 import org.apache.drill.exec.expr.holders.IntHolder;
 import org.apache.drill.exec.expr.holders.VarBinaryHolder;
 
-@FunctionTemplate(name = "convert_fromINT_BE", scope = FunctionScope.SIMPLE, 
nulls = NullHandling.NULL_IF_NULL)
+@FunctionTemplate(names = {"convert_fromINT_BE", "convert_fromUINT4_BE"},
+    scope = FunctionScope.SIMPLE, nulls = NullHandling.NULL_IF_NULL)
 public class IntBEConvertFrom implements DrillSimpleFunc {
 
   @Param VarBinaryHolder in;
{noformat}

Instead if add an alias for UINT4_BE which confusingly returns a signed int, 
could you please add new function like UInt8ConvertFrom and UInt8ConvertTo.

Rest looks good.

> Prune scan range if the filter is on the leading field with byte comparable 
> encoding
> ------------------------------------------------------------------------------------
>
>                 Key: DRILL-3364
>                 URL: https://issues.apache.org/jira/browse/DRILL-3364
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Storage - HBase
>            Reporter: Aditya Kishore
>            Assignee: Smidth Panchamia
>             Fix For: 1.2.0
>
>         Attachments: 
> 0001-Add-convert_from-and-convert_to-methods-for-TIMESTAM.patch, 
> 0001-DRILL-3364-Prune-scan-range-if-the-filter-is-on-the-.patch, 
> 0001-DRILL-3364-Prune-scan-range-if-the-filter-is-on-the-.patch, 
> 0001-DRILL-3364-Prune-scan-range-if-the-filter-is-on-the-.patch, 
> composite.jun26.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to