[
https://issues.apache.org/jira/browse/DRILL-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647811#comment-14647811
]
Jim Scott commented on DRILL-3423:
----------------------------------
Jacques,
Couple comments about the code:
1. There is a next() method with the magic number 4095 in it. Curious as to the
relevance.
2. This plugin seems like it would be a great way to showcase how easy it is to
plugin new functionality for file formats. If you could add some comments about
what you have going on in the code it would help tremendously.
3. In the bootstrap setup section you add this new format. I'm wondering what
might be able to be done within drill to support the common practices for log
rotation file formats. They usually start with error or access and then have a
date pattern after them.
Regarding the URI breakdown, the functionality for breaking a field down
already exists in this library, so exposing it as a UDF makes sense as it would
be able to be used regardless of whether the source of the log was an apache
server or not.
Jim
> Add New HTTPD format plugin
> ---------------------------
>
> Key: DRILL-3423
> URL: https://issues.apache.org/jira/browse/DRILL-3423
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - Other
> Reporter: Jacques Nadeau
> Assignee: Jacques Nadeau
> Fix For: 1.2.0
>
>
> Add an HTTPD logparser based format plugin. The author has been kind enough
> to move the logparser project to be released under the Apache License. Can
> find it here:
> <dependency>
> <groupId>nl.basjes.parse.httpdlog</groupId>
> <artifactId>httpdlog-parser</artifactId>
> <version>2.0</version>
> </dependency>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
