[ 
https://issues.apache.org/jira/browse/DRILL-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648538#comment-14648538
 ] 

Adam Gilmore commented on DRILL-3319:
-------------------------------------

The AggregateErrorFunctions class.  During codegen for say, the streaming 
aggregate, it generates a template which includes those functions, but the 
template doesn't declare a static logger, therefore you end up with a 
CompileException with "logger" does not exist.

Easy way to test this is to do a simple aggregation on a string field:

{code}
select sum(mystringfield) from table
{code}

You'll get the logger exception instead of the nice "you can't aggregate a 
varchar column" error from that class.

> UserExceptions should be logged from the right class
> ----------------------------------------------------
>
>                 Key: DRILL-3319
>                 URL: https://issues.apache.org/jira/browse/DRILL-3319
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: DRILL-3319.1.patch.txt, DRILL-3319.3.patch.txt
>
>
> Currently system errors are logged using the UserException#logger. Classes 
> that throws UserException should delegate logging to UserException#build 
> method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to