[
https://issues.apache.org/jira/browse/DRILL-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694327#comment-14694327
]
ASF GitHub Bot commented on DRILL-2625:
---------------------------------------
GitHub user cwestin opened a pull request:
https://github.com/apache/drill/pull/109
DRILL-2625: StackTrace format to match JDK's Throwable's format
Small changes to the StackTrace class to make its output match the JDK's
Throwable format so that IDEs and other tools can parse it (and use that
information to jump to file-lines, etc).
Unit tests pass.
Regression tests pass, except for the known small parquet file problem
(DRILL-3635), and the intermediate fragment distribution timeout (DRILL-3480).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwestin/incubator-drill alloc-stacktrace
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit 77d26872b967effb8959188529f49529d637d82a
Author: Chris Westin <[email protected]>
Date: 2015-08-12T17:22:05Z
DRILL-2625: StackTrace format to match JDK's Throwable's format
----
> org.apache.drill.common.StackTrace should follow standard stacktrace format
> ---------------------------------------------------------------------------
>
> Key: DRILL-2625
> URL: https://issues.apache.org/jira/browse/DRILL-2625
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 0.8.0
> Reporter: Daniel Barclay (Drill)
> Assignee: Chris Westin
> Fix For: 1.2.0
>
>
> org.apache.drill.common.StackTrace uses a different textual format than JDK's
> standard format for stack traces.
> It should probably use the standard format so that its stack trace output can
> be used by tools that already can parse the standard format to provide
> functionality such as displaying the corresponding source.
> (After correcting for DRILL-2624, StackTrace formats stack traces like this:
> org.apache.drill.common.StackTrace.<init>:1
> org.apache.drill.exec.server.Drillbit.run:20
> org.apache.drill.jdbc.DrillConnectionImpl.<init>:232
> The normal form is like this:
> at
> org.apache.drill.exec.memory.TopLevelAllocator.close(TopLevelAllocator.java:162)
> at
> org.apache.drill.exec.server.BootStrapContext.close(BootStrapContext.java:75)
> at com.google.common.io.Closeables.close(Closeables.java:77)
> )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
