[
https://issues.apache.org/jira/browse/DRILL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701882#comment-14701882
]
ASF GitHub Bot commented on DRILL-1942:
---------------------------------------
GitHub user cwestin opened a pull request:
https://github.com/apache/drill/pull/120
DRILL-1942-hygiene
- Formatting
- @Overrides
- finals
- some AutoCloseable additions needed for upcoming patches
- new isCancelled() abstract method on FragmentManager, implemented on
subclasses;
Added missing new abstract method isCancelled(); needed for upcoming patches
Unit tests passed
Precommit suite passed (except for Windows)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwestin/incubator-drill hygiene-alpha
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 993844f2088ec7348a1faf106c1cc2a251b7d0c9
Author: Chris Westin <[email protected]>
Date: 2015-08-17T22:42:28Z
DRILL-1942-hygiene
- Formatting
- @Overrides
- finals
- some AutoCloseable additions
- new isCancelled() abstract method on FragmentManager, implemented on
subclasses
Added missing new abstract method isCancelled()
----
> Improve off-heap memory usage tracking
> --------------------------------------
>
> Key: DRILL-1942
> URL: https://issues.apache.org/jira/browse/DRILL-1942
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Chris Westin
> Assignee: Chris Westin
> Fix For: 1.2.0
>
> Attachments: DRILL-1942.1.patch.txt, DRILL-1942.2.patch.txt,
> DRILL-1942.3.patch.txt
>
>
> We're using a lot more memory than we think we should. We may be leaking it,
> or not releasing it as soon as we could.
> This is a call to come up with some improved tracking so that we can get
> statistics out about exactly where we're using it, and whether or not we can
> release it earlier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
