[ 
https://issues.apache.org/jira/browse/DRILL-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Sinha updated DRILL-3666:
------------------------------
    Assignee: Jinfeng Ni  (was: Aman Sinha)

> Replace assert uses in Drill's interpreter to catch error when it happens. 
> ---------------------------------------------------------------------------
>
>                 Key: DRILL-3666
>                 URL: https://issues.apache.org/jira/browse/DRILL-3666
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.1.0
>            Reporter: Jinfeng Ni
>            Assignee: Jinfeng Ni
>         Attachments: 
> 0001-DRILL-3666-Replace-assert-check-in-InterpreterEvalua.patch
>
>
> Some code in interpreter uses assert to check certain conditions. However, if 
>  assertion enabled (-ea) is not turned on, such checking would skip. That 
> might cause issues, since the caller may not know an error has happened in 
> the interpreter, and will continue the execution.  This has caused issue in 
> partition pruning recently, when a bug in partition pruning passes an invalid 
> expression to interpreter, yet the assert checking was skipped and end up 
> with incorrect query result. 
> In stead, we should remove assert in interpreter, and make sure throw 
> exception when certain conditions are not met. It's up the caller to decide 
> what to do in the case of exception.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to