[
https://issues.apache.org/jira/browse/DRILL-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705246#comment-14705246
]
ASF GitHub Bot commented on DRILL-3583:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/123#discussion_r37552037
--- Diff:
common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
@@ -534,6 +535,19 @@ public UserException build(final Logger logger) {
return newException;
}
+
+ /**
+ * builds a user exception or returns the wrapped one. If the error is
a system error, the error message is logged
+ * to the given {@link Logger}.
--- End diff --
you should probably update this comment
*the error message is logged to the UserException's logger*
> SUM on varchar column produces incorrect error
> ----------------------------------------------
>
> Key: DRILL-3583
> URL: https://issues.apache.org/jira/browse/DRILL-3583
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Codegen
> Affects Versions: 1.1.0
> Reporter: Adam Gilmore
> Assignee: Parth Chandra
> Fix For: 1.2.0
>
> Attachments: DRILL-3583.1.patch.txt
>
>
> With the implementation of DRILL-3319, a bug was introduced whereby the
> codegen for an aggregate when SUMing a varchar column fails:
> {code}
> 0: jdbc:drill:zk=local> select sum(full_name) from cp.`employee.json`;
> java.lang.RuntimeException: java.sql.SQLException: SYSTEM ERROR:
> CompileException: Line 57, Column 177: Unknown variable or type "logger"
> Fragment 0:0
> [Error Id: 8d5585c4-620c-4275-b0c5-8bc4cbc2da90 on
> pharma-lap14.ad.pharmadata.net.au:31010]
> at sqlline.IncrementalRows.hasNext(IncrementalRows.java:73)
> at
> sqlline.TableOutputFormat$ResizingRowsProvider.next(TableOutputFormat.java:87)
> at sqlline.TableOutputFormat.print(TableOutputFormat.java:118)
> at sqlline.SqlLine.print(SqlLine.java:1583)
> at sqlline.Commands.execute(Commands.java:852)
> at sqlline.Commands.sql(Commands.java:751)
> at sqlline.SqlLine.dispatch(SqlLine.java:738)
> at sqlline.SqlLine.begin(SqlLine.java:612)
> at sqlline.SqlLine.start(SqlLine.java:366)
> at sqlline.SqlLine.main(SqlLine.java:259)
> {code}
> This is due to the fact AggregateErrorFunctions now builds its errors with a
> "logger" static field, which does not exist in the codegenned code.
> We either need to include a static logger in codegen aggregates, or revert
> back to simpler exceptions for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
