[
https://issues.apache.org/jira/browse/DRILL-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721249#comment-14721249
]
Deneche A. Hakim commented on DRILL-3707:
-----------------------------------------
(In the PR, if you click on "Files Changed" and comment there, the comment will
remain in the PR discussion even after the PR is rebased. But if you comment on
the commits directly, those comments are lost whenever the PR is rebased)
2. this change is not required to fix this issue. I factored the code to move
the test before the loop. The way the previous test was written, if batchGroups
contained only 1 batch then we wouldn't run the for loop, thus returning null.
[~sphillips] could definitely give us more information about this.
> Fix for DRILL-3616 can cause a NullPointerException in ExternalSort cleanup
> ---------------------------------------------------------------------------
>
> Key: DRILL-3707
> URL: https://issues.apache.org/jira/browse/DRILL-3707
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Reporter: Deneche A. Hakim
> Assignee: Deneche A. Hakim
> Fix For: 1.2.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
