[
https://issues.apache.org/jira/browse/DRILL-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721568#comment-14721568
]
ASF GitHub Bot commented on DRILL-3724:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/139#discussion_r38272883
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
@@ -115,6 +115,10 @@ public boolean isBlockSplittable() {
return blockSplittable;
}
+ /** Whether or not this format could also be in a compression container
(for example: csv.gz versus csv).
+ * This is an external compression container that would be handled
outside of the format code.
+ * This is an internal compression scheme, not supported by Parquet.
--- End diff --
A little unclear. Maybe "If this format uses its own internal compression
scheme, such as Parquet does, then this should return false."
> Improve javadoc/documentation of the fundamental interfaces and abstract
> classes.
> ---------------------------------------------------------------------------------
>
> Key: DRILL-3724
> URL: https://issues.apache.org/jira/browse/DRILL-3724
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Codegen, Execution - Data Types, Execution -
> Flow, Execution - Relational Operators, Execution - RPC
> Affects Versions: 1.2.0, Future
> Reporter: Edmon Begoli
> Assignee: Chris Westin
> Priority: Trivial
> Labels: easyfix
> Fix For: 1.2.0
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Add better source code documentation describing the core methods and classes
> - org.apache.drill.common.logical.FormatPluginConfig, AbstractStoragePlugin,
> AbstractBase,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
