[
https://issues.apache.org/jira/browse/DRILL-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724810#comment-14724810
]
ASF GitHub Bot commented on DRILL-3535:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/140#discussion_r38386365
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -104,6 +107,9 @@ public WorkspaceSchemaFactory(DrillConfig drillConfig,
FileSystemPlugin plugin,
final FormatMatcher fallbackMatcher = new
BasicFormatMatcher(formatPlugin,
ImmutableList.of(Pattern.compile(".*")),
ImmutableList.<MagicString>of());
fileMatchers.add(fallbackMatcher);
+ dropFileMatchers = fileMatchers.subList(0, fileMatchers.size() - 1);
--- End diff --
Why would we have different matchers for drop file. Shouldn't we simply
share the behavior across all matching behaviors?
> Drop table support
> ------------------
>
> Key: DRILL-3535
> URL: https://issues.apache.org/jira/browse/DRILL-3535
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Mehant Baid
> Assignee: Mehant Baid
>
> Umbrella JIRA to track support for "Drop table" feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
