[
https://issues.apache.org/jira/browse/DRILL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739288#comment-14739288
]
ASF GitHub Bot commented on DRILL-1942:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/120#discussion_r39194893
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentManager.java
---
@@ -38,36 +37,43 @@
* @return True if the fragment has enough incoming data to be able to
be run.
* @throws FragmentSetupException, IOException
*/
- public abstract boolean handle(RawFragmentBatch batch) throws
FragmentSetupException, IOException;
+ boolean handle(RawFragmentBatch batch) throws FragmentSetupException,
IOException;
/**
* Get the fragment runner for this incoming fragment. Note, this can
only be requested once.
*
* @return
*/
- public abstract FragmentExecutor getRunnable();
+ FragmentExecutor getRunnable();
+
+ void cancel();
- public abstract void cancel();
+ /**
+ * Find out if the FragmentManager has been cancelled.
+ *
+ * @return true if the FragmentManager has been cancelled.
+ */
+ boolean isCancelled();
--- End diff --
My bad.. I did not see that mentioned in the commit message, and I did not
realize the PR was made with comments in addition to the commit message.
> Improve off-heap memory usage tracking
> --------------------------------------
>
> Key: DRILL-1942
> URL: https://issues.apache.org/jira/browse/DRILL-1942
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Chris Westin
> Assignee: Chris Westin
> Fix For: 1.2.0
>
> Attachments: DRILL-1942.1.patch.txt, DRILL-1942.2.patch.txt,
> DRILL-1942.3.patch.txt
>
>
> We're using a lot more memory than we think we should. We may be leaking it,
> or not releasing it as soon as we could.
> This is a call to come up with some improved tracking so that we can get
> statistics out about exactly where we're using it, and whether or not we can
> release it earlier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
