[ 
https://issues.apache.org/jira/browse/DRILL-3493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741035#comment-14741035
 ] 

Victoria Markman commented on DRILL-3493:
-----------------------------------------

Yes, exception injector throwing OOM will test cancellation implicitly and this 
is very important test. However, having forman cancel query when reached 
cancellation site is a different test. It's much closer to cancellation user is 
going to issue explicitly.
We will only be able to test on a single node, but that's a good way to start, 
plus we will be able to have automated test suite.

> Alter session command with an option to cancel query in a particular phase of 
> execution
> ---------------------------------------------------------------------------------------
>
>                 Key: DRILL-3493
>                 URL: https://issues.apache.org/jira/browse/DRILL-3493
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - Flow
>            Reporter: Victoria Markman
>            Assignee: Deneche A. Hakim
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> This proposal is to implement: 
> "alter session cancel <execution phase> = true|false".
> where <execution phase> is an entry point for query cancellation, like say 
> "sort" or "disk based sort" , etc.
> When this option is set, if query reaches this point, forman would issue 
> cancel.
> This way: we can easily test correctness of query cancellation in different 
> types of queries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to