[
https://issues.apache.org/jira/browse/DRILL-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741475#comment-14741475
]
ASF GitHub Bot commented on DRILL-1942:
---------------------------------------
GitHub user cwestin opened a pull request:
https://github.com/apache/drill/pull/154
DRILL-1942-readers:
- add extends AutoCloseable to RecordReader, and rename cleanup() to
close() on derived classes.
- fix many warnings
- formatting fixes
unit tests pass
presubmit regression and customer passes
presubmit tpc-h SF100 passes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwestin/incubator-drill alloc-readers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 2b23db2dcc1a6548b6f791379678b9df6ceece27
Author: Chris Westin <[email protected]>
Date: 2015-09-11T01:28:00Z
DRILL-1942-readers:
- add extends AutoCloseable to RecordReader, and rename cleanup() to
close().
- fix many warnings
- formatting fixes
----
> Improve off-heap memory usage tracking
> --------------------------------------
>
> Key: DRILL-1942
> URL: https://issues.apache.org/jira/browse/DRILL-1942
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Chris Westin
> Assignee: Chris Westin
> Fix For: 1.2.0
>
> Attachments: DRILL-1942.1.patch.txt, DRILL-1942.2.patch.txt,
> DRILL-1942.3.patch.txt
>
>
> We're using a lot more memory than we think we should. We may be leaking it,
> or not releasing it as soon as we could.
> This is a call to come up with some improved tracking so that we can get
> statistics out about exactly where we're using it, and whether or not we can
> release it earlier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
