[
https://issues.apache.org/jira/browse/DRILL-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742308#comment-14742308
]
ASF GitHub Bot commented on DRILL-3767:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/155#discussion_r39343893
--- Diff:
common/src/main/java/org/apache/drill/common/expression/SchemaPath.java ---
@@ -220,9 +214,6 @@ public boolean contains(Object obj) {
}
SchemaPath other = (SchemaPath) obj;
- if (rootSegment == null) {
--- End diff --
One can indeed pass a null rootSegment to the constructor. If this is
something that shouldn't happen, maybe I can just add an assertion in the
constructors, otherwise I will revert back the change in this function
> SchemaPath.getCompoundPath(String...strings) reverses it's input array
> ----------------------------------------------------------------------
>
> Key: DRILL-3767
> URL: https://issues.apache.org/jira/browse/DRILL-3767
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Codegen
> Reporter: Deneche A. Hakim
> Assignee: Aman Sinha
> Priority: Minor
> Fix For: 1.2.0
>
>
> If you pass an array of strings to {{SchemaPath.getCompoundPath()}}, the
> input array will be reversed. This side effect is *undocumented* and has led
> to at least one known bug DRILL-3758
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
