[
https://issues.apache.org/jira/browse/DRILL-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deneche A. Hakim updated DRILL-3811:
------------------------------------
Attachment: DRILL-3811.1.patch.txt
- fixed AtomicRemainder.forceGet(int)
- removed assertion in AtomicRemainder.returnAllocation(long) that asserts the
allocator never uses more than it's maximum allocated, but this assertion may
no longer holds when a buffer's ownership is transferred to an allocator
- added unit test to TestAllocators to make sure the issue has been fixed
> AtomicRemainder incorrectly accounts for transferred allocations
> ----------------------------------------------------------------
>
> Key: DRILL-3811
> URL: https://issues.apache.org/jira/browse/DRILL-3811
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Reporter: Deneche A. Hakim
> Assignee: Deneche A. Hakim
> Attachments: DRILL-3811.1.patch.txt
>
>
> when an allocator takes ownership of a buffer, AtomicRemainder.forceGet(int)
> is called to account for the extra memory of the buffer, but when the
> allocator exceeds it's maximum allocated memory it accounts for it
> incorrectly. In the following code, {{availableShared.andAndGet(size)}}
> should actually receive {{-size}}:
> {code}
> public boolean forceGet(long size) {
> if (get(size, this.applyFragmentLimit)) {
> return true;
> } else {
> availableShared.addAndGet(size);
> if (parent != null) {
> parent.forceGet(size);
> }
> return false;
> }
> }
> {code}
> I was able to reproduce the issue in a simple unit test
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
