[
https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901000#comment-14901000
]
ASF GitHub Bot commented on DRILL-1065:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39996854
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -83,14 +84,30 @@ public OptionValue getOption(final String name) {
*/
abstract boolean setLocalOption(OptionValue value);
+ /**
+ * Deletes the option with given name for this manager without falling
back.
+ *
+ * @param type option type
+ * @return true iff the option was successfully deleted
--- End diff --
this javadoc can have multiple meanings: _successfully deleted_ could
either mean the implementation couldn't find the option, or it doesn't support
the option type. It should actually return false if it doesn't support the
option type
> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
> Key: DRILL-1065
> URL: https://issues.apache.org/jira/browse/DRILL-1065
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Aman Sinha
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very
> useful to have a 'reset' command to reset the value of an option to its
> default system value:
> ALTER SESSION RESET <option name>
> If we don't want to add a new keyword for RESET, we could potentially
> overload the SET command and allow the user to set to the 'default' value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
