[
https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901025#comment-14901025
]
ASF GitHub Bot commented on DRILL-1065:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r39998161
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/TestOptions.java ---
@@ -46,19 +48,207 @@ public void testOptions() throws Exception{
@Test
public void checkValidationException() throws Exception {
thrownException.expect(new UserExceptionMatcher(VALIDATION));
- test(String.format("ALTER session SET `%s` = '%s';",
ExecConstants.SLICE_TARGET, "fail"));
+ test("ALTER session SET `%s` = '%s';", SLICE_TARGET, "fail");
}
@Test // DRILL-3122
public void checkChangedColumn() throws Exception {
- test(String.format("ALTER session SET `%s` = %d;",
ExecConstants.SLICE_TARGET,
+ test(String.format("ALTER session SET `%s` = %d;", SLICE_TARGET,
--- End diff --
you can remove `String.format` here too
> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
> Key: DRILL-1065
> URL: https://issues.apache.org/jira/browse/DRILL-1065
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Aman Sinha
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very
> useful to have a 'reset' command to reset the value of an option to its
> default system value:
> ALTER SESSION RESET <option name>
> If we don't want to add a new keyword for RESET, we could potentially
> overload the SET command and allow the user to set to the 'default' value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
