[
https://issues.apache.org/jira/browse/DRILL-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905229#comment-14905229
]
ASF GitHub Bot commented on DRILL-3822:
---------------------------------------
GitHub user dsbos opened a pull request:
https://github.com/apache/drill/pull/166
DRILL-3822: Have PathScanner use own, not thread-context, class loader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsbos/incubator-drill bugs/drill-3822
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #166
----
commit 605a65780a38da2e1e8e35c521876e68e5901cab
Author: dbarclay <[email protected]>
Date: 2015-09-23T01:04:45Z
DRILL-3822: Have PathScanner use own, not thread-context, class loader.
----
> PathScanner fails to find jdbc-all's drill-module.conf in SQuirreL
> ------------------------------------------------------------------
>
> Key: DRILL-3822
> URL: https://issues.apache.org/jira/browse/DRILL-3822
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.2.0
> Reporter: Krystal
> Assignee: Daniel Barclay (Drill)
> Attachments: squirrel.log
>
>
> git.commit.id.abbrev=3c89b30
> I used the latest drill-jdbc-all-1.2.0-SNAPSHOT.jar against the SQuirreL SQL
> application. I got the following error when trying to connect to the drill
> data source:
> {noformat}
> ERROR net.sourceforge.squirrel_sql.client.gui.db.ConnectToAliasCallBack -
> Unexpected Error occurred attempting to open an SQL connection.
> java.util.concurrent.ExecutionException: java.lang.RuntimeException:
> oadd.com.typesafe.config.ConfigException$Missing: No configuration setting
> found for key 'drill.exec'
> Full error message is in the attached file.
> {noformat}
> We turned on logging and found that the jdbc-all Jar file's
> {{drill-module.conf}} file was not being found (explaining why the
> configuration key {{drill.exec}} wasn't found).
> After further investigation, it seems that {{PathScanner}} directly uses the
> system class loader, bypassing the context class loader.
> (After drill-jdbc-all-1.2.0-SNAPSHOT.jar was changed from being listed in
> SQuirreL's "additional class paths" (presumably being loaded by a special
> class loader) to being copied into SQuirreL's Jar file directory (and
> therefore loaded by the system class loader), SQuirreL worked. (Apparently,
> {{PathScanner}} was then able to find {{drill-module.conf}} in the JDBC-all
> Jar file and load it, so the later reference to {{drill.exec}} no longer
> failed.)
> Also, SQuirreL works correctly with drill-1.1's JDBC-all Jar file, and there
> were some recent changes to {{PathScanner}} related to class loaders.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
