[
https://issues.apache.org/jira/browse/DRILL-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908336#comment-14908336
]
ASF GitHub Bot commented on DRILL-2489:
---------------------------------------
GitHub user dsbos opened a pull request:
https://github.com/apache/drill/pull/171
Bugs/drill 2769 2489 jdbc exceptions
DRILL-2489: Throw exception from remaining methods for closed JDBC objects.
DRILL-2769: Fix most non-SQLException not-supported-yet exceptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsbos/incubator-drill
bugs/drill-2769_2489_JDBC_exceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #171
----
commit 90bf53dee9407d40065a820a6f0b7a35cf54fbea
Author: dbarclay <[email protected]>
Date: 2015-08-19T23:55:40Z
DRILL-2489: Throw exception from remaining methods for closed JDBC objects.
Refactored unit test to check all methods per interface. (Replaced
individual,
static test methods with bulk reflection-based checking.)
[Drill2489CallsAfterCloseThrowExceptionsTest]
Added DrillResultSetMetaDataImpl.
Added method overrides to check state for remaining methods from Connection,
Statement, PreparedStatement, ResultSet, ResultSetMetaData and
DatabaseMetaData.
Also:
- renamed checkNotClosed to throwIfClosed.
commit fb960d8be27c3a810474caedfe4a0890fd0222ac
Author: dbarclay <[email protected]>
Date: 2015-08-27T21:05:26Z
DRILL-2769: Fix most non-SQLException not-supported-yet exceptions.
Core:
Added (auto-scanning) unit test.
[Drill2769UnsupportedReportsUseSqlExceptionTest]
Added translation of lots of UnsupportedOperationExceptions (and some
RuntimeExceptions) from Avatica code to SQLFeatureNotSupportedExceptions
(tons
of method overrides).
Also:
Added explicit bounds checks in ResultSetMetaData methods and checking of
last-accessed column in DrillAccessorList.wasNull() (to fix other
RuntimeExceptions to SQLExceptions).
Added resetting of last-accessed column to fix latent bug in
DrillAccessorList.
Hygiene:
- Renamed some zero-based index/ordinal-position parameters to "...Offset".
- Renamed some one-based index/ordinal-position parameters to "...Number".
- Renamed DrillAccessorList lastColumn to rowLastColumnOffset; declared
explicit logical null value for rowLastColumnOffset.
----
> Accessing Connection, Statement, PreparedStatement after they are closed
> should throw a SQLException
> ----------------------------------------------------------------------------------------------------
>
> Key: DRILL-2489
> URL: https://issues.apache.org/jira/browse/DRILL-2489
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Reporter: Rahul Challapalli
> Assignee: Daniel Barclay (Drill)
> Fix For: 1.2.0
>
>
> git.commit.id.abbrev=7b4c887
> According to JDBC spec we should throw a SQLException when we access methods
> on a closed Connection, Statement, or PreparedStatement. Drill is currently
> not doing it.
> I can raise multiple JIRA's if the developer wishes to work on them
> independently
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
