[
https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939289#comment-14939289
]
ASF GitHub Bot commented on DRILL-1065:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/159#discussion_r40877406
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
---
@@ -102,6 +125,29 @@ public void setOption(OptionValue value) {
}
@Override
+ public void deleteOption(final String name, final OptionType type) {
+ try {
+ SystemOptionManager.getValidator(name); // ensure the option exists
+ } catch (final IllegalArgumentException e) {
+ throw UserException.validationError(e)
+ .build(logger);
--- End diff --
Initially, I made that change in the ```getValidator``` function, but it
seemed like UserException was one level too deep (if that makes sense). This
way the calling function can do whatever it wants with the exception e.g. wrap
it in a UserException for the user, or ignore it in case of a unit test.
> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>
> Key: DRILL-1065
> URL: https://issues.apache.org/jira/browse/DRILL-1065
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: Aman Sinha
> Assignee: Sudheesh Katkam
> Priority: Minor
> Fix For: 1.2.0
>
>
> Within a session, currently we set configuration options and it would be very
> useful to have a 'reset' command to reset the value of an option to its
> default system value:
> ALTER SESSION RESET <option name>
> If we don't want to add a new keyword for RESET, we could potentially
> overload the SET command and allow the user to set to the 'default' value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
