[
https://issues.apache.org/jira/browse/DRILL-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953895#comment-14953895
]
ASF GitHub Bot commented on DRILL-3920:
---------------------------------------
Github user hnfgns commented on a diff in the pull request:
https://github.com/apache/drill/pull/194#discussion_r41808483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
@@ -355,17 +353,19 @@ public void generateTestData(int values) { }
@Override
public void clear() {
- valueCount = 0;
- for (ValueVector v : getChildren()) {
+ for (final ValueVector v : getChildren()) {
v.clear();
}
+ valueCount = 0;
}
@Override
public void close() {
- for (final ValueVector v : getChildren()) {
+ final Collection<ValueVector> vectors = getChildren();
--- End diff --
super.close() and resetting value count should be just fine here.
remaining seems redundant if I am not missing anything.
> Add vector loading tests
> ------------------------
>
> Key: DRILL-3920
> URL: https://issues.apache.org/jira/browse/DRILL-3920
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
> Affects Versions: 1.2.0
> Reporter: Chris Westin
> Assignee: Chris Westin
>
> Add some additional tests to TestValueVector to test serialization and
> reloading of vectors, as well as the underlying buffer slicing operations
> that are used for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
