[
https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957258#comment-14957258
]
ASF GitHub Bot commented on DRILL-3927:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/199#discussion_r42020509
--- Diff:
common/src/main/java/org/apache/drill/common/DeferredException.java ---
@@ -47,6 +75,15 @@ public void addException(final Exception exception) {
Preconditions.checkState(!isClosed);
if (this.exception == null) {
+ if (exceptionSupplier == null) {
+ this.exception = exception;
+ } else {
+ this.exception = exceptionSupplier.get();
+ if (this.exception == null) {
+ this.exception = new RuntimeException("Missing root
exception");
+ }
+ this.exception.addSuppressed(exception);
+ }
this.exception = exception;
--- End diff --
should we remove this line ?
> Use OutOfMemoryException in more places
> ---------------------------------------
>
> Key: DRILL-3927
> URL: https://issues.apache.org/jira/browse/DRILL-3927
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Reporter: Chris Westin
> Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional
> exception handling sites need to catch and handle this exception in
> preparation for the new allocator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)