[
https://issues.apache.org/jira/browse/DRILL-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957696#comment-14957696
]
ASF GitHub Bot commented on DRILL-3930:
---------------------------------------
Github user hnfgns commented on the pull request:
https://github.com/apache/drill/pull/200#issuecomment-148187351
+1
> Remove direct references to TopLevelAllocator from unit tests
> -------------------------------------------------------------
>
> Key: DRILL-3930
> URL: https://issues.apache.org/jira/browse/DRILL-3930
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 1.2.0
> Reporter: Chris Westin
> Assignee: Chris Westin
>
> The RootAllocatorFactory should be used throughout the code to allow us to
> change allocators via configuration or other software choices. Some unit
> tests still reference TopLevelAllocator directly. We also need to do a better
> job of handling exceptions that can be handled by close()ing an allocator
> that isn't in the proper state (remaining open child allocators, outstanding
> buffers, etc).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
