[
https://issues.apache.org/jira/browse/DRILL-3912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964349#comment-14964349
]
ASF GitHub Bot commented on DRILL-3912:
---------------------------------------
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/189#issuecomment-149390932
If the only bug you saw is in Scalar Replacement after turning on CSE for
other operators, would it make sense to open a different JIRA to track the SR
bug, and fix the SR bug there? From what I tried, the run-time generated code
seems to be valid, and would produce the correct query result, if SR is
disabled for that query.
> Common subexpression elimination in code generation
> ---------------------------------------------------
>
> Key: DRILL-3912
> URL: https://issues.apache.org/jira/browse/DRILL-3912
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Steven Phillips
> Assignee: Jinfeng Ni
>
> Drill currently will evaluate the full expression tree, even if there are
> redundant subtrees. Many of these redundant evaluations can be eliminated by
> reusing the results from previously evaluated expression trees.
> For example,
> {code}
> select a + 1, (a + 1)* (a - 1) from t
> {code}
> Will compute the entire (a + 1) expression twice. With CSE, it will only be
> evaluated once.
> The benefit will be reducing the work done when evaluating expressions, as
> well as reducing the amount of code that is generated, which could also lead
> to better JIT optimization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
