[ https://issues.apache.org/jira/browse/DRILL-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967863#comment-14967863 ]
ASF GitHub Bot commented on DRILL-3802: --------------------------------------- Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/209#discussion_r42679515 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java --- @@ -305,6 +313,105 @@ public SqlNode visit(SqlCall sqlCall) { return sqlCall.getOperator().acceptCall(this, sqlCall); } + private void checkRollupCubeGrpSets(SqlSelect sqlSelect) { + final ExprFinder rollupCubeGrpSetsFinder = new ExprFinder(RollupCubeGrpSets); + sqlSelect.accept(rollupCubeGrpSetsFinder); + if (rollupCubeGrpSetsFinder.find()) { + unsupportedOperatorCollector.setException(SqlUnsupportedException.ExceptionType.FUNCTION, --- End diff -- Good point. I'll create an enhancement JIRA and point to the enhancement JIRA in the error msg. > Throw unsupported error for ROLLUP/GROUPING > ------------------------------------------- > > Key: DRILL-3802 > URL: https://issues.apache.org/jira/browse/DRILL-3802 > Project: Apache Drill > Issue Type: New Feature > Reporter: Victoria Markman > Assignee: Aman Sinha > > I believe that this is the cause of assertions in TPCDS #36, #67 > {code} > SELECT Sum(ss_net_profit) / Sum(ss_ext_sales_price) AS > gross_margin, > i_category, > i_class, > Grouping(i_category) + Grouping(i_class) AS > lochierarchy, > Rank() > OVER ( > partition BY Grouping(i_category)+Grouping(i_class), CASE > WHEN Grouping( > i_class) = 0 THEN i_category END > ORDER BY Sum(ss_net_profit)/Sum(ss_ext_sales_price) ASC) AS > rank_within_parent > FROM store_sales, > date_dim d1, > item, > store > WHERE d1.d_year = 2000 > AND d1.d_date_sk = ss_sold_date_sk > AND i_item_sk = ss_item_sk > AND s_store_sk = ss_store_sk > AND s_state IN ( 'TN', 'TN', 'TN', 'TN', > 'TN', 'TN', 'TN', 'TN' ) > GROUP BY rollup( i_category, i_class ) > ORDER BY lochierarchy DESC, > CASE > WHEN lochierarchy = 0 THEN i_category > END, > rank_within_parent > LIMIT 100; > Error: SYSTEM ERROR: AssertionError: Internal error: invariant violated: > conversion result not null > [Error Id: 6afae7ce-c426-44f3-a600-aa34ab7632a1 on ucs-node5.perf.lab:31010] > (state=,code=0) > java.sql.SQLException: SYSTEM ERROR: AssertionError: Internal error: > invariant violated: conversion result not null > [Error Id: 6afae7ce-c426-44f3-a600-aa34ab7632a1 on ucs-node5.perf.lab:31010] > at > org.apache.drill.jdbc.impl.DrillCursor.nextRowInternally(DrillCursor.java:247) > at > org.apache.drill.jdbc.impl.DrillCursor.loadInitialSchema(DrillCursor.java:290) > at > org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:1359) > at > org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:74) > at > net.hydromatic.avatica.AvaticaConnection.executeQueryInternal(AvaticaConnection.java:404) > at > net.hydromatic.avatica.AvaticaStatement.executeQueryInternal(AvaticaStatement.java:351) > at > net.hydromatic.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:338) > at net.hydromatic.avatica.AvaticaStatement.execute(AvaticaStatement.java:69) > at > org.apache.drill.jdbc.impl.DrillStatementImpl.execute(DrillStatementImpl.java:86) > at sqlline.Commands.execute(Commands.java:841) > at sqlline.Commands.sql(Commands.java:751) > at sqlline.SqlLine.dispatch(SqlLine.java:738) > at sqlline.SqlLine.runCommands(SqlLine.java:1641) > at sqlline.Commands.run(Commands.java:1304) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at sqlline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:36) > at sqlline.SqlLine.dispatch(SqlLine.java:734) > at sqlline.SqlLine.initArgs(SqlLine.java:544) > at sqlline.SqlLine.begin(SqlLine.java:587) > at sqlline.SqlLine.start(SqlLine.java:366) > at sqlline.SqlLine.main(SqlLine.java:259) > Caused by: org.apache.drill.common.exceptions.UserRemoteException: SYSTEM > ERROR: AssertionError: Internal error: invariant violated: conversion result > not null > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)