[ 
https://issues.apache.org/jira/browse/DRILL-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981524#comment-14981524
 ] 

ASF GitHub Bot commented on DRILL-3963:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/214#discussion_r43455368
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java
 ---
    @@ -258,8 +286,35 @@ public void 
testMultiLevelImpersonationJoinOneSideExceedsMaxUserHops() throws Ex
     
         assertNotNull("UserRemoteException is expected", ex);
         assertThat(ex.getMessage(),
    -        containsString("Cannot issue token for view expansion as issuing 
the token exceeds the maximum allowed number " +
    -            "of user hops (3) in chained impersonation"));
    +      containsString("Cannot issue token for view expansion as issuing the 
token exceeds the maximum allowed number " +
    +        "of user hops (3) in chained impersonation"));
    +  }
    +
    +  @Test
    +  public void sequenceFileChainedImpersonationWithView() throws Exception {
    +    // create a view named "simple_seq_view" on "simple.seq". View is 
owned by user0:group0 and has permissions 750
    +    createView(org1Users[0], org1Groups[0], "simple_seq_view",
    +      String.format("SELECT convert_from(t.binary_key, 'UTF8') as k FROM 
%s.`%s` t", MINIDFS_STORAGE_PLUGIN_NAME,
    +        new Path(getUserHome(org1Users[0]), "simple.seq")));
    +    try {
    +      updateClient(org1Users[1]);
    +      test("SELECT k FROM %s.%s.%s", MINIDFS_STORAGE_PLUGIN_NAME, "tmp", 
"simple_seq_view");
    +    } catch (UserRemoteException e) {
    +      assertNull("This test should pass.", e);
    +    }
    +  }
    +
    +  @Test
    +  public void avroChainedImpersonationWithView() throws Exception {
    --- End diff --
    
    I am curious.. Did this test fail without the impersonation changes in 
AvroRecordReader?


> Read raw key value bytes from sequence files
> --------------------------------------------
>
>                 Key: DRILL-3963
>                 URL: https://issues.apache.org/jira/browse/DRILL-3963
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: amit hadke
>            Assignee: amit hadke
>
> Sequence files store list of key-value pairs. Keys/values are of type hadoop 
> writable.
> Provide a format plugin that reads raw bytes out of sequence files which can 
> be further deserialized by a udf(from hadoop writable -> drill type)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to