[
https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983287#comment-14983287
]
ASF GitHub Bot commented on DRILL-3232:
---------------------------------------
Github user StevenMPhillips commented on a diff in the pull request:
https://github.com/apache/drill/pull/207#discussion_r43550594
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
@@ -275,83 +275,86 @@ private void consumeEntireNextValue() throws
IOException {
private void writeData(MapWriter map, FieldSelection selection, boolean
moveForward) throws IOException {
//
map.start();
- outside: while (true) {
-
- JsonToken t;
- if(moveForward){
- t = parser.nextToken();
- }else{
- t = parser.getCurrentToken();
- moveForward = true;
- }
+ try {
--- End diff --
Yes, I am pretty sure that is the case. I don't remember why exactly I
needed to put this in a try-finally block.
> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
> Key: DRILL-3232
> URL: https://issues.apache.org/jira/browse/DRILL-3232
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Codegen, Execution - Data Types, Execution -
> Relational Operators, Functions - Drill
> Reporter: Steven Phillips
> Assignee: Hanifi Gunes
> Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported
> implicit casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
