[ 
https://issues.apache.org/jira/browse/DRILL-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986423#comment-14986423
 ] 

ASF GitHub Bot commented on DRILL-3941:
---------------------------------------

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/230#discussion_r43706257
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
 ---
    @@ -166,16 +174,28 @@ protected void doOnMatch(RelOptRuleCall call, 
DrillFilterRel filterRel, DrillPro
         }
     
         if (partitionColumnBitSet.isEmpty()) {
    -      logger.debug("No partition columns are projected from the 
scan..continue.");
    +      logger.info("No partition columns are projected from the 
scan..continue. " +
    +          "Total pruning elapsed time: {} ms", 
totalPruningTime.elapsed(TimeUnit.MILLISECONDS));
    --- End diff --
    
    When the pruning rule does early return due to non-applicability, the 
'Total pruning elapsed time' message could be misleading since it did not 
actually do pruning.


> Add timing instrumentation around Partition Pruning
> ---------------------------------------------------
>
>                 Key: DRILL-3941
>                 URL: https://issues.apache.org/jira/browse/DRILL-3941
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Aman Sinha
>
> We seem to spending a chunk time doing partition pruning, it would be good to 
> log timing information to indicate the amount of time we spend doing pruning. 
> A little more granularity to indicate the time taken to build the filter tree 
> and in the interpreter would also be good.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to