[
https://issues.apache.org/jira/browse/DRILL-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986833#comment-14986833
]
ASF GitHub Bot commented on DRILL-951:
--------------------------------------
Github user abhipol commented on a diff in the pull request:
https://github.com/apache/drill/pull/232#discussion_r43721299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java
---
@@ -71,15 +79,14 @@ public CompliantTextRecordReader(FileSplit split,
DrillFileSystem dfs, FragmentC
// checks to see if we are querying all columns(star) or individual
columns
@Override
public boolean isStarQuery() {
- if(settings.isUseRepeatedVarChar()) {
- return super.isStarQuery() || Iterables.tryFind(getColumns(), new
Predicate<SchemaPath>() {
- @Override
- public boolean apply(@Nullable SchemaPath path) {
- return path.equals(RepeatedVarCharOutput.COLUMNS);
- }
- }).isPresent();
- }
- return super.isStarQuery();
+ if (super.isStarQuery()) { return true; }
--- End diff --
not sure if I understood your suggestion. it does work with columns[] (ext
csv) and named field cases (ext csvh), star and non star queries.
Since it was not function of UseRepeatedVarChar I simplified the code
> CSV header row should be parsed
> -------------------------------
>
> Key: DRILL-951
> URL: https://issues.apache.org/jira/browse/DRILL-951
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - Text & CSV
> Reporter: Tomer Shiran
> Assignee: Abhijit Pol
> Fix For: Future
>
>
> CSV reader is currently treating header names like regular rows. There should
> be a way to treat the header row as the column names (optional?).
> I exported this dataset to a CSV:
> https://data.sfgov.org/Public-Safety/SFPD-Incidents-Previous-Three-Months/tmnf-yvry
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
