[
https://issues.apache.org/jira/browse/DRILL-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994842#comment-14994842
]
ASF GitHub Bot commented on DRILL-4047:
---------------------------------------
Github user julienledem commented on a diff in the pull request:
https://github.com/apache/drill/pull/246#discussion_r44204847
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -313,19 +734,29 @@ public String getTypeName() {
return FileSystemConfig.NAME;
}
+ private DrillTable isReadable(FormatMatcher m, FileSelection
fileSelection) throws IOException {
+ return m.isReadable(fs, fileSelection, plugin, storageEngineName,
schemaConfig.getUserName());
+ }
+
@Override
- public DrillTable create(String key) {
+ public DrillTable create(TableInstance key) {
try {
- FileSelection fileSelection = FileSelection.create(fs,
config.getLocation(), key);
+ FileSelection fileSelection = FileSelection.create(fs,
config.getLocation(), key.sig.name);
if (fileSelection == null) {
return null;
}
-
+ if (key.sig.params.size() > 0) {
+ FormatPluginConfig fconfig = optionExtractor.eval(key);
+// TextFormatPlugin.TextFormatConfig fconfig = new
TextFormatPlugin.TextFormatConfig();
+// fconfig.extensions = Arrays.asList();
+// fconfig.fieldDelimiter = ((String)key.params.get(0)).charAt(0);
--- End diff --
todo: cleanup
> Select with options
> -------------------
>
> Key: DRILL-4047
> URL: https://issues.apache.org/jira/browse/DRILL-4047
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> Add a mechanism to pass parameters down to the StoragePlugin when writing a
> Select statement.
> Some discussion here:
> http://mail-archives.apache.org/mod_mbox/drill-dev/201510.mbox/%3CCAO%2Bvc4AcGK3%2B3QYvQV1-xPPdpG3Tc%2BfG%3D0xDGEUPrhd6ktHv5Q%40mail.gmail.com%3E
> http://mail-archives.apache.org/mod_mbox/drill-dev/201511.mbox/%3ccao+vc4clzylvjevisfjqtcyxb-zsmfy4bqrm-jhbidwzgqf...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
