[ 
https://issues.apache.org/jira/browse/DRILL-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118374#comment-15118374
 ] 

ASF GitHub Bot commented on DRILL-4196:
---------------------------------------

GitHub user amithadke opened a pull request:

    https://github.com/apache/drill/pull/338

    DRILL-4196 Fix to stop returning no more data when output batch is fu…

    …ll during merge.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amithadke/drill DRILL-4196

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #338
    
----
commit 4cd7800ab0e41bd41c9aecf75b87533c117e187d
Author: Amit Hadke <[email protected]>
Date:   2016-01-27T00:52:25Z

    DRILL-4196 Fix to stop returning no more data when output batch is full 
during merge.

----


> some TPCDS queries return wrong result when hash join is disabled
> -----------------------------------------------------------------
>
>                 Key: DRILL-4196
>                 URL: https://issues.apache.org/jira/browse/DRILL-4196
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Victoria Markman
>            Assignee: amit hadke
>         Attachments: 1.5.0-amit-branch_tpcds_sf1.txt, query40.tar, query52.tar
>
>
> With hash join disabled query52.sql and query40.sql returned incorrect result 
> with 1.4.0 :
> {noformat}
> +-----------------+-------------------------------------------+---------------------------------------------------------------------+----------------------------+--------------+----------------------------+
> |     version     |                 commit_id                 |               
>             commit_message                            |        commit_time    
>      | build_email  |         build_time         |
> +-----------------+-------------------------------------------+---------------------------------------------------------------------+----------------------------+--------------+----------------------------+
> | 1.4.0-SNAPSHOT  | b9068117177c3b47025f52c00f67938e0c3e4732  | DRILL-4165 
> Add a precondition for size of merge join record batch.  | 08.12.2015 @ 
> 01:25:34 UTC  | Unknown      | 08.12.2015 @ 03:36:25 UTC  |
> +-----------------+-------------------------------------------+---------------------------------------------------------------------+----------------------------+--------------+----------------------------+
> 1 row selected (2.13 seconds)
> {noformat}
> Setup and options are the same as in DRILL-4190
> See attached queries (.sql), expected result (.e_tsv) and actual output (.out)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to