[
https://issues.apache.org/jira/browse/DRILL-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122213#comment-15122213
]
ASF GitHub Bot commented on DRILL-2653:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/343#discussion_r51177764
--- Diff: exec/java-exec/src/main/resources/rest/storage/update.ftl ---
@@ -53,8 +53,17 @@
});
function doUpdate() {
$("#updateForm").ajaxForm(function(data) {
- $("#message").removeClass("hidden").text(data.result).alert();
- setTimeout(function() { location.reload(); }, 800);
+ var messageEl = $("#message");
+ messageEl.addClass("hidden");
+ // Wait a fraction of a second before showing the message again.
This
+ // makes it clear if a second attempt gives the same error as
+ // the first that a "new" message came back from the server
+ setTimeout(function() {
+ messageEl.removeClass("hidden").text("Please retry: " +
data.result).alert();
--- End diff --
This alert will show even if the update succeeds, right?
> All additions to storage plugin configuration gets wiped out if info is not
> correct
> ------------------------------------------------------------------------------------
>
> Key: DRILL-2653
> URL: https://issues.apache.org/jira/browse/DRILL-2653
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
> Affects Versions: 0.9.0
> Reporter: Krystal
> Fix For: Future
>
> Attachments: DRILL-2653.1.patch.txt
>
>
> Whenever a user enters an invalid information into a storage plugin
> configuration, the entire data gets wiped out. This can be frustrating to
> users if alot of information has been entered. The data should be retained
> on the screen to allow users correct the mistakes rather than having to write
> all the information over again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
