[
https://issues.apache.org/jira/browse/DRILL-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132661#comment-15132661
]
ASF GitHub Bot commented on DRILL-4314:
---------------------------------------
Github user jaltekruse commented on a diff in the pull request:
https://github.com/apache/drill/pull/339#discussion_r51908667
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java ---
@@ -235,6 +240,20 @@ public CSVTestBuilder csvBaselineFile(String filePath)
{
expectedNumBatches);
}
+ public SchemaTestBuilder schemaBaseLine(List<Pair<SchemaPath,
TypeProtos.MajorType>> expectedSchema) {
+ assert expectedSchema != null : "The expected schema can be provided
once";
+ assert baselineColumns == null : "The column information should be
captured in expected schem, not baselineColumns";
--- End diff --
Could you add a few tests to the TestFrameworkTest that hit these
conditions? It would be good if future changes to the test builder that may
cause some currently-valid test configurations to fail (or currently invalid
configurations to be allowed) would be detected by the tests for the framework
itself.
> Unit Test Framework Enhancement: Schema check for zero-row query
> ----------------------------------------------------------------
>
> Key: DRILL-4314
> URL: https://issues.apache.org/jira/browse/DRILL-4314
> Project: Apache Drill
> Issue Type: New Feature
> Components: Tools, Build & Test
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Sean Hsuan-Yi Chu
> Fix For: 1.6.0
>
>
> Given the improvement for the Limit-Zero is going through development, the
> unit test Framework should offer Schema Check for zero-row query
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
