[
https://issues.apache.org/jira/browse/DRILL-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135229#comment-15135229
]
ASF GitHub Bot commented on DRILL-4361:
---------------------------------------
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/365
DRILL-4361: Let FileSystemPlugin FormatCreator class be overridable
Allow for FileSystemPlugin subclasses to customize FormatPlugin by
injecting their own version of FormatCreator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill
laurent/filesystem-custom-format-plugins
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #365
----
----
> Allow for FileSystemPlugin subclasses to override FormatCreator
> ---------------------------------------------------------------
>
> Key: DRILL-4361
> URL: https://issues.apache.org/jira/browse/DRILL-4361
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Minor
>
> FileSystemPlugin subclasses are not able to customize plugins, as
> FormatCreator in created in FileSystemPlugin constructor and immediately used
> to create SchemaFactory instance.
> FormatCreator instantiation should be moved to a protected method so that
> subclass can choose to implement it differently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
