[ 
https://issues.apache.org/jira/browse/DRILL-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168345#comment-15168345
 ] 

ASF GitHub Bot commented on DRILL-4354:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/360#discussion_r54200801
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java
 ---
    @@ -102,4 +112,34 @@ public void dispose(DrillUserPrincipal principal) {
           // No-Op
         }
       }
    +
    +  // Provider which creates and cleanups DrillUserPrincipal for anonymous 
(auth disabled) mode
    +  public static class AnonDrillUserPrincipalProvider implements 
Factory<DrillUserPrincipal> {
    +    @Inject WorkManager workManager;
    +
    +    @RequestScoped
    +    @Override
    +    public DrillUserPrincipal provide() {
    +      return new AnonDrillUserPrincipal(workManager.getContext());
    +    }
    +
    +    @Override
    +    public void dispose(DrillUserPrincipal principal) {
    +      // If this worked it would have been clean to free the resources 
here, but there are various scenarios
    --- End diff --
    
    Any [specific tickets](https://java.net/jira/browse/JERSEY/)?


> Remove sessions in anonymous (user auth disabled) mode in WebUI server
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4354
>                 URL: https://issues.apache.org/jira/browse/DRILL-4354
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.5.0
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 1.6.0
>
>
> Currently we open anonymous sessions when user auth disabled. These sessions 
> are cleaned up when they expire (controlled by boot config 
> {{drill.exec.http.session_max_idle_secs}}). This may lead to unnecessary 
> resource accumulation. This JIRA is to remove anonymous sessions and only 
> have sessions when user authentication is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to