[
https://issues.apache.org/jira/browse/DRILL-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212031#comment-15212031
]
ASF GitHub Bot commented on DRILL-4504:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/429#discussion_r57460954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -50,8 +52,12 @@
public BootStrapContext(DrillConfig config, ScanResult classpathScan) {
this.config = config;
this.classpathScan = classpathScan;
- this.loop =
TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
"BitServer-");
- this.loop2 =
TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
"BitClient-");
+ this.controlLoopGroup =
TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
--- End diff --
You're effectively doubling the number of threads with your current change.
:/
> Create an event loop for each of [user, control, data] RPC components
> ---------------------------------------------------------------------
>
> Key: DRILL-4504
> URL: https://issues.apache.org/jira/browse/DRILL-4504
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - RPC
> Reporter: Sudheesh Katkam
> Assignee: Sudheesh Katkam
>
> + Create an event loop group for each client-server pair (data, client and
> user)
> + Allow DrillClient constructor to specify an event loop group (so user event
> loop can be used for queries from Web API calls). Deprecate old DrillClient
> constructors and create a helper class to build instances.
> Miscellaneous:
> + Move WorkEventBus from exec/rpc/control to exec/work
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
