[
https://issues.apache.org/jira/browse/DRILL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215120#comment-15215120
]
ASF GitHub Bot commented on DRILL-4549:
---------------------------------------
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/450#issuecomment-202632855
lgtm
> Add support for more truncation units in date_trunc function
> ------------------------------------------------------------
>
> Key: DRILL-4549
> URL: https://issues.apache.org/jira/browse/DRILL-4549
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
> Fix For: 1.7.0
>
>
> Currently we support only {{YEAR, MONTH, DAY, HOUR, MINUTE, SECOND}} truncate
> units for types {{TIME, TIMESTAMP and DATE}}. Extend the functions to support
> {{YEAR, MONTH, DAY, HOUR, MINUTE, SECOND, WEEK, QUARTER, DECADE, CENTURY,
> MILLENNIUM}} truncate units for types {{TIME, TIMESTAMP, DATE, INTERVAL DAY,
> INTERVAL YEAR}}.
> Also get rid of the if-and-else (on truncation unit) implementation. Instead
> resolve to a direct function based on the truncation unit in Calcite -> Drill
> (DrillOptiq) expression conversion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
