[
https://issues.apache.org/jira/browse/DRILL-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220862#comment-15220862
]
ASF GitHub Bot commented on DRILL-4544:
---------------------------------------
Github user vkorukanti commented on a diff in the pull request:
https://github.com/apache/drill/pull/448#discussion_r58144615
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java
---
@@ -64,6 +65,11 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws
ValidationException, RelConv
final SchemaPlus schema =
findSchema(config.getConverter().getDefaultSchema(),
refreshTable.getSchemaPath());
+ if (schema == null) {
+ return direct(false, "Storage plugin or workspace does not exist
[%s]",
--- End diff --
Why not just throw a UserException? That way SqlLine or scripts know an
error has occurred.
> Improve error messages for REFRESH TABLE METADATA command
> ---------------------------------------------------------
>
> Key: DRILL-4544
> URL: https://issues.apache.org/jira/browse/DRILL-4544
> Project: Apache Drill
> Issue Type: Improvement
> Components: Metadata
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Minor
> Fix For: 1.7.0
>
>
> Improve the error messages thrown by REFRESH TABLE METADATA command:
> In the first case below, the error is maprfs.abc doesn't exist. It should
> throw a Object not found or workspace not found. It is currently throwing a
> non helpful message;
> 0: jdbc:drill:> refresh table metadata maprfs.abc.`my_table`;
> --------------------+
> ok summary
> --------------------+
> false Error: null
> --------------------+
> 1 row selected (0.355 seconds)
> In the second case below, it says refresh table metadata is supported only
> for single-directory based Parquet tables. But the command works for nested
> multi-directory Parquet files.
> 0: jdbc:drill:> refresh table metadata maprfs.vnaranammalpuram.`rfm_sales_vw`;
> -----------+
> ok summary
> -----------+
> false Table rfm_sales_vw does not support metadata refresh. Support is
> currently limited to single-directory-based Parquet tables.
> -----------+
> 1 row selected (0.418 seconds)
> 0: jdbc:drill:>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
