[
https://issues.apache.org/jira/browse/DRILL-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271472#comment-15271472
]
ASF GitHub Bot commented on DRILL-4642:
---------------------------------------
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62118608
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -734,6 +772,41 @@ public static FunctionCall
convertSqlOperatorBindingToFunctionCall(final SqlOper
}
/**
+ * Based on whether decimal type is supported or not, this method
creates an ExplicitOperatorBinding which interprets
+ * the type of decimal literals accordingly.
+ */
+ public static SqlOperatorBinding convertDecimalLiteralToDouble(final
SqlOperatorBinding sqlOperatorBinding, final boolean isDecimalSupported) {
+ final List<RelDataType> types = Lists.newArrayList();
+ for(int i = 0; i < sqlOperatorBinding.getOperandCount(); ++i) {
+ final RelDataType relDataType;
+ if(isDecimalLiteral(sqlOperatorBinding, i) && !isDecimalSupported) {
+ relDataType = createCalciteTypeWithNullability(
+ sqlOperatorBinding.getTypeFactory(),
+ SqlTypeName.DOUBLE,
+ sqlOperatorBinding.getOperandType(i).isNullable());
+ } else {
+ relDataType = sqlOperatorBinding.getOperandType(i);
+ }
+ types.add(relDataType);
+ }
+ return new
ExplicitOperatorBinding(sqlOperatorBinding.getTypeFactory(),
sqlOperatorBinding.getOperator(), types);
--- End diff --
addressed.
> Let RexBuilder.ensureType() mechanism take place during Rex conversion.
> -----------------------------------------------------------------------
>
> Key: DRILL-4642
> URL: https://issues.apache.org/jira/browse/DRILL-4642
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Sean Hsuan-Yi Chu
> Fix For: 1.7.0
>
>
> In DRILL-4372, the logic of ensuring same type is removed since, in some case
> such as below, undesirable cast function will be added and cause failure.
> {code}
> SELECT *
> FROM T
> WHERE (cast(col1 as timestamp) - to_timestamp(col2,'YYYY-MM-dd HH:mm:ss') <
> interval 'X XX:XX:XX' day to second)
> {code}
> The fundamental reason for this behavior roots in Drill-Calcite [1], where
> SqlNode WHERE is expanded to a new object but is not passed into validation
> step.
> [1]
> https://github.com/mapr/incubator-calcite/blob/DrillCalcite1.4.0-mapr-1.4.0/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L3362
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
