[
https://issues.apache.org/jira/browse/DRILL-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285661#comment-15285661
]
ASF GitHub Bot commented on DRILL-4676:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63444805
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -296,7 +295,7 @@ public void run() {
* would wait on the cancelling thread to signal a resume and the
cancelling thread would wait on the Foreman
* to accept events.
*/
- acceptExternalEvents.countDown();
+ stateSwitch.start();
--- End diff --
that is true indeed, I didn't notice the Foreman was also using the event
queue before it counted down the latch. I will update the fix to respect this
behavior
> Foreman.moveToState can block forever if called by the foreman thread while
> the query is still being setup
> ----------------------------------------------------------------------------------------------------------
>
> Key: DRILL-4676
> URL: https://issues.apache.org/jira/browse/DRILL-4676
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow
> Affects Versions: 1.6.0
> Reporter: Deneche A. Hakim
> Assignee: Sudheesh Katkam
> Fix For: 1.7.0
>
>
> When the query is being setup, foreman has a special CountDownLatch that
> blocks rpc threads from delivering external events, this latch is unblocked
> at the end of the query setup.
> In some cases though, when the foreman is submitting remote fragments, a
> failure in RpcBus.send() causes an exception to be thrown that is reported to
> Foreman.FragmentSubmitListener and blocks in the CountDownLatch. This causes
> the foreman thread to block forever, and can rpc threads to be blocked too.
> This seems to happen more frequently at a high concurrency load, and also can
> prevent clients from connecting to the Drillbits.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
