[
https://issues.apache.org/jira/browse/DRILL-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289460#comment-15289460
]
ASF GitHub Bot commented on DRILL-4606:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/480#discussion_r63751912
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -53,6 +54,8 @@ public BootStrapContext(DrillConfig config, ScanResult
classpathScan) {
this.loop2 =
TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
"BitClient-");
// Note that metrics are stored in a static instance
this.metrics = DrillMetrics.getRegistry();
+ this.userLoopGroup =
TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.USER_SERVER_RPC_THREADS),
--- End diff --
shouldn't this change be part of a different pull request ? doesn't seem
related to adding DrillClient.Builder
> Create DrillClient.Builder class
> --------------------------------
>
> Key: DRILL-4606
> URL: https://issues.apache.org/jira/browse/DRILL-4606
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Sudheesh Katkam
> Assignee: Sudheesh Katkam
>
> + Create a helper class to build DrillClient instances, and deprecate
> DrillClient constructors
> + Allow DrillClient to specify an event loop group (so user event loop can be
> used for queries from Web API calls)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
