[
https://issues.apache.org/jira/browse/DRILL-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306131#comment-15306131
]
ASF GitHub Bot commented on DRILL-4199:
---------------------------------------
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/443#discussion_r65015118
--- Diff:
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
---
@@ -21,34 +21,36 @@
import java.util.Set;
import org.apache.calcite.schema.SchemaPlus;
-
import org.apache.drill.common.JSONOptions;
import org.apache.drill.exec.ops.OptimizerRulesContext;
import org.apache.drill.exec.server.DrillbitContext;
import org.apache.drill.exec.store.AbstractStoragePlugin;
import org.apache.drill.exec.store.SchemaConfig;
import org.apache.drill.exec.store.StoragePluginOptimizerRule;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.Connection;
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.collect.ImmutableSet;
public class HBaseStoragePlugin extends AbstractStoragePlugin {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HBaseStoragePlugin.class);
+ private static final HBaseConnectionManager hbaseConnectionManager =
HBaseConnectionManager.INSTANCE;
--- End diff --
Any reason you use static here as opposed to one per storage plugin
instance? I suppose this reduces overhead in the case of multiple plugin
instances to a single target but generally, I'd be inclined to just have an
instance per plugin.
> Add Support for HBase 1.X
> -------------------------
>
> Key: DRILL-4199
> URL: https://issues.apache.org/jira/browse/DRILL-4199
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - HBase
> Affects Versions: 1.7.0
> Reporter: Divjot singh
> Assignee: Aditya Kishore
>
> Is there any Road map to upgrade the Hbase version to 1.x series. Currently
> drill supports Hbase 0.98 version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
