[
https://issues.apache.org/jira/browse/DRILL-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317496#comment-15317496
]
Jinfeng Ni commented on DRILL-4707:
-----------------------------------
[~jnadeau], I cherry-picked your CALCITE-528 patch to Drill's forked calcite,
made some change in uniquify() method in Calcite. The patch did fix the memory
problem and incorrect query result. I also looked your CALCITE-528 patch, and
the changes make sense to me. Here is the link [1] :
I run the pre-commit and unit test with the patch, and did not see any failure.
I plan to push your CALCITE-528 patch to Drill's forked calcite branch, and
update Drill with the above PR (The version number will be updated). Can you
please take a look (both Calcite branch and Drill) ?
[1]
https://github.com/jinfengni/incubator-optiq/tree/DrillCalcite1.4.0_CALCITE528
> Conflicting columns names under case-insensitive policy lead to either memory
> leak or incorrect result
> ------------------------------------------------------------------------------------------------------
>
> Key: DRILL-4707
> URL: https://issues.apache.org/jira/browse/DRILL-4707
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Priority: Critical
>
> On latest master branch:
> {code}
> select version, commit_id, commit_message from sys.version;
> +-----------------+-------------------------------------------+---------------------------------------------------------------------------------+
> | version | commit_id |
> commit_message |
> +-----------------+-------------------------------------------+---------------------------------------------------------------------------------+
> | 1.7.0-SNAPSHOT | 3186217e5abe3c6c2c7e504cdb695567ff577e4c | DRILL-4607:
> Add a split function that allows to separate string by a delimiter |
> +-----------------+-------------------------------------------+---------------------------------------------------------------------------------+
> {code}
> If a query has two conflicting column names under case-insensitive policy,
> Drill will either hit memory leak, or incorrect issue.
> Q1.
> {code}
> select r_regionkey as XYZ, r_name as xyz FROM cp.`tpch/region.parquet`;
> Error: SYSTEM ERROR: IllegalStateException: Memory was leaked by query.
> Memory leaked: (131072)
> Allocator(op:0:0:1:Project) 1000000/131072/2490368/10000000000
> (res/actual/peak/limit)
> Fragment 0:0
> {code}
> Q2: return only one column in the result.
> {code}
> select n_nationkey as XYZ, n_regionkey as xyz FROM cp.`tpch/nation.parquet`;
> +------+
> | XYZ |
> +------+
> | 0 |
> | 1 |
> | 1 |
> | 1 |
> | 4 |
> | 0 |
> | 3 |
> {code}
> The cause of the problem seems to be that the Project thinks the two incoming
> columns as identical (since Drill adopts case-insensitive for column names in
> execution).
> The planner should make sure that the conflicting columns are resolved, since
> execution is name-based.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
