[ 
https://issues.apache.org/jira/browse/DRILL-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320875#comment-15320875
 ] 

ASF GitHub Bot commented on DRILL-4664:
---------------------------------------

GitHub user vdiravka opened a pull request:

    https://github.com/apache/drill/pull/516

    DRILL-4664: ScanBatch.isNewSchema() returns wrong result for map datatype

    - creating a separate SchemaChangeCallBack for new MapVecor in 
MapTransferPair,
      RepeatedMapTransferPair and SingleMapTransferPair .

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vdiravka/drill DRILL-4664

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #516
    
----
commit 7ebc091e44a0b7c77ec59e07c0bbb7c887bf69d7
Author: Vitalii Diravka <[email protected]>
Date:   2016-06-08T13:32:42Z

    DRILL-4664: ScanBatch.isNewSchema() returns wrong result for map datatype
    
    - creating a separate SchemaChangeCallBack for new MapVecor in 
MapTransferPair,
      RepeatedMapTransferPair and SingleMapTransferPair .

----


> ScanBatch.isNewSchema() returns wrong result for map datatype
> -------------------------------------------------------------
>
>                 Key: DRILL-4664
>                 URL: https://issues.apache.org/jira/browse/DRILL-4664
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.6.0
>            Reporter: Vitalii Diravka
>            Priority: Minor
>
> isNewSchema() method checks if top-level schema or any of the deeper map 
> schemas has changed. The last one doesn't work properly with count function.
> "deeperSchemaChanged" equals true even when two map strings have the same 
> children fields.
> Discovered while trying to fix [DRILL-2385|DRILL-2385].
> Dataset test.json for reproducing (MAP<REQUIRED> datatype object):
> {code}{"oooi":{"oa":{"oab":{"oabc":1}}}}{code}
> Example of query:
> {code}select count(t.oooi) from dfs.tmp.`test.json` t{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to