[ 
https://issues.apache.org/jira/browse/DRILL-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329686#comment-15329686
 ] 

ASF GitHub Bot commented on DRILL-4715:
---------------------------------------

GitHub user jinfengni opened a pull request:

    https://github.com/apache/drill/pull/521

    DRILL-4715: Fix java compilation error in run-time generated code whe…

    …n query has large number of expressions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinfengni/incubator-drill DRILL-4715

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #521
    
----
commit 600b01dcaddc2e8e9cb95f728c263ebcfa7441e5
Author: Jinfeng Ni <[email protected]>
Date:   2016-06-10T00:08:45Z

    DRILL-4715: Fix java compilation error in run-time generated code when 
query has large number of expressions.

----


> Java compilation error for a query with large number of expressions
> -------------------------------------------------------------------
>
>                 Key: DRILL-4715
>                 URL: https://issues.apache.org/jira/browse/DRILL-4715
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Jinfeng Ni
>
> The following query would hit compilation error, when Drill generates and 
> compiles the run-time code. 
> Q1 :
> {code}
> select  expr1, expr2, expr3, ...., exprN
> from table
> {code} 
> In Q1, expr1, expr2, ..., exprN are non-trivial expression (in stead of 
> simply column reference), and N is big enough, then the run-time generated 
> code may have a method which goes beyond the 64k limit imposed by JVM. 
> This seems to be a regression from DRILL-3912 (Common subexpression 
> elimination). CSE tries to put as many expressions in one block as possible, 
> to detect and eliminate as many CSE as possible. However, this implies we may 
> end up with big method with compilation error.
>     



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to